-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: add provide function #7952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7952 +/- ##
==========================================
- Coverage 91.80% 91.80% -0.01%
==========================================
Files 509 509
Lines 17452 17456 +4
Branches 2684 2684
==========================================
+ Hits 16022 16025 +3
- Misses 1136 1137 +1
Partials 294 294
|
This proposal is based on the package dimension. like:
provideAnimations API List more... so because there are too many configuration items, it is not necessary to provide a function for each sub item |
@simplejason 你好,麻烦看下这个PR是否可以合入,如果不需要合入的话我可以关闭这个PR :) |
@simplejason 我支持此PR,它的灵感来源于自 Angular14 之后推出的一系列 provide* 函数,这些助手函数为用户提供了更便捷的方法来配置 provider,并且类型安全。 |
目前有可能保留原有的使用方式但标注 deprecated 吗?看上去用户升级后会出现 break change |
现在只是提供了一系列provide的function,原使用方式目前不影响,provide的函数是为了日后取消了module而做准备,文档也引导用户使用provide |
这里不会出现 breaking change,我们应该移除这个 label 😊 |
@MunMunMiao provide function 和原来的使用方式是等价的,我觉得 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #7953
What is the new behavior?
See: #7953
Does this PR introduce a breaking change?
Other information