Skip to content

fix(module: list): fix the bug that synchrone action item are not displayed in the item #7958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

Nicoss54
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Bug fix where asynchrone actions are not display in an item of a list

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Asynchrone action item are not displayed in the item.

Issue Number: #7954

What is the new behavior?

Asynchronous action item list are now displayed

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Nicoss54 Nicoss54 requested a review from cipchk as a code owner May 24, 2023 09:48
@Nicoss54 Nicoss54 requested a review from simplejason May 24, 2023 09:48
@Nicoss54 Nicoss54 self-assigned this May 24, 2023
@zorro-bot
Copy link

zorro-bot bot commented May 24, 2023

This preview will be available after the AzureCI is passed.

@Nicoss54 Nicoss54 linked an issue May 24, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #7958 (f4182d7) into master (605e969) will increase coverage by 91.69%.
The diff coverage is 100.00%.

❗ Current head f4182d7 differs from pull request most recent head 06f06a6. Consider uploading reports for the commit 06f06a6 to get more accurate results

@@             Coverage Diff             @@
##           master    #7958       +/-   ##
===========================================
+ Coverage        0   91.69%   +91.69%     
===========================================
  Files           0      514      +514     
  Lines           0    17573    +17573     
  Branches        0     2690     +2690     
===========================================
+ Hits            0    16113    +16113     
- Misses          0     1165     +1165     
- Partials        0      295      +295     
Impacted Files Coverage Δ
components/list/list-item-cell.ts 96.00% <100.00%> (ø)

... and 513 files with indirect coverage changes

@Nicoss54 Nicoss54 force-pushed the fix/asynchrone-list-action branch from a41d89b to 7b682de Compare June 26, 2023 08:05
@Nicoss54
Copy link
Collaborator Author

@simplejason can i merge this one when the CI pass ? This PR allow to display an asynchronous action on list component

@Nicoss54 Nicoss54 force-pushed the fix/asynchrone-list-action branch from 06f06a6 to 18adde3 Compare July 11, 2023 06:36
@simplejason simplejason changed the title fix/asynchrone-list-action fix(module: list): fix the bug that synchrone action item are not displayed in the item Jul 16, 2023
@simplejason
Copy link
Member

@simplejason can i merge this one when the CI pass ? This PR allow to display an asynchronous action on list component

Sorry for the late reply, free free to merge any PRs that are approved or confirmed as correct :) Nits: Make sure you follow the CONTRIBUTING.md.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 3b6bdec into NG-ZORRO:master Jul 16, 2023
@Nicoss54 Nicoss54 deleted the fix/asynchrone-list-action branch August 18, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-list-item-actions not rendering with ngFor
2 participants