Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): fix code comment #7991

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

cxb1021
Copy link
Contributor

@cxb1021 cxb1021 commented Jun 20, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
fix code comment in date picker component

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[☑︎] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[☑︎] No

Other information

@cxb1021 cxb1021 requested a review from wenqi73 as a code owner June 20, 2023 15:30
@zorro-bot
Copy link

zorro-bot bot commented Jun 20, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #7991 (9d72baa) into master (198644a) will increase coverage by 91.81%.
The diff coverage is n/a.

❗ Current head 9d72baa differs from pull request most recent head ed98d7b. Consider uploading reports for the commit ed98d7b to get more accurate results

@@             Coverage Diff             @@
##           master    #7991       +/-   ##
===========================================
+ Coverage        0   91.81%   +91.81%     
===========================================
  Files           0      509      +509     
  Lines           0    17452    +17452     
  Branches        0     2774     +2774     
===========================================
+ Hits            0    16024    +16024     
- Misses          0     1135     +1135     
- Partials        0      293      +293     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 95.25% <ø> (ø)

... and 508 files with indirect coverage changes

@simplejason simplejason merged commit 8b6b653 into NG-ZORRO:master Jul 16, 2023
@cxb1021 cxb1021 deleted the fix-code-comment branch October 16, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants