Skip to content

feat(module:cron-expression): add Unit Testing #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

OriginRing
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 21, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #7993 (a5478a1) into master (6d31bde) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head a5478a1 differs from pull request most recent head 37d5670. Consider uploading reports for the commit 37d5670 to get more accurate results

@@            Coverage Diff             @@
##           master    #7993      +/-   ##
==========================================
- Coverage   91.80%   91.69%   -0.11%     
==========================================
  Files         509      514       +5     
  Lines       17452    17573     +121     
  Branches     2774     2690      -84     
==========================================
+ Hits        16022    16114      +92     
- Misses       1136     1164      +28     
- Partials      294      295       +1     
Impacted Files Coverage Δ
...nents/cron-expression/cron-expression.component.ts 77.01% <100.00%> (ø)

... and 6 files with indirect coverage changes

@OriginRing OriginRing force-pushed the fix/cron-expression-test branch from 2bc7f56 to 37d5670 Compare June 25, 2023 01:54
@Laffery Laffery merged commit 605e969 into NG-ZORRO:master Jun 25, 2023
@OriginRing OriginRing deleted the fix/cron-expression-test branch March 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants