-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(module:notification): don't create new messageId for update #8000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:notification): don't create new messageId for update #8000
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #8000 +/- ##
===========================================
+ Coverage 0 91.70% +91.70%
===========================================
Files 0 514 +514
Lines 0 17574 +17574
Branches 0 2690 +2690
===========================================
+ Hits 0 16117 +16117
- Misses 0 1162 +1162
- Partials 0 295 +295
|
@simplejason could you check why the Pipeline is not trigger ? still in the same status Waiting for status to be reported |
ad6eb2f
to
6e77b95
Compare
It’s fix ;) |
6e77b95
to
8c555d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
This PR is a fix for generating a new messageId for updating notification
What is the current behavior?
When we update a notification, the service generate a new messageId
Issue Number: 7975
What is the new behavior?
When we update a notification, the service don't generate a new messageId
Does this PR introduce a breaking change?