Skip to content

feat(module:input): hide stepper for type number #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented Jul 4, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

have the possibility to hide or show native stepper for input of type number

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7956

What is the new behavior?

It's now possible to have the possibility to hide or show the stepper with the directive nz-input and the type number

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Nicoss54 Nicoss54 requested review from vthinkxie and cipchk as code owners July 4, 2023 09:53
@zorro-bot
Copy link

zorro-bot bot commented Jul 4, 2023

This preview will be available after the AzureCI is passed.

@Nicoss54 Nicoss54 self-assigned this Jul 4, 2023
@Nicoss54 Nicoss54 linked an issue Jul 4, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #8003 (867f651) into master (7f7c155) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 867f651 differs from pull request most recent head 871b145. Consider uploading reports for the commit 871b145 to get more accurate results

@@           Coverage Diff           @@
##           master    #8003   +/-   ##
=======================================
  Coverage   91.64%   91.65%           
=======================================
  Files         515      515           
  Lines       17640    17641    +1     
  Branches     2790     2790           
=======================================
+ Hits        16167    16169    +2     
+ Misses       1175     1174    -1     
  Partials      298      298           
Files Changed Coverage Δ
components/input/input.directive.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Nicoss54 Nicoss54 force-pushed the feature/stepper-input-type-number branch from cbdce13 to 53a9e8c Compare July 11, 2023 06:30
@@ -29,6 +29,7 @@ All props of input supported by [w3c standards](https://www.w3schools.com/tags/t
| `[nzAutosize]` | Only used for `textarea`, height autosize feature, can be set to `boolean` or an object `{ minRows: 2, maxRows: 6 }` | `boolean \| { minRows: number, maxRows: number }` | `false` |
| `[nzBorderless]` | Whether hide border | `boolean` | `false` |
| `[nzStatus]` | Set validation status | `'error' \| 'warning'` | - |
| `[nzStepperless]` | Whether hide stepper when input type is number | `'boolean' \| 'true'` | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zh-CN:
| [nzStepperless] | 输入框类型为 number 时是否隐藏 step 效果 |

@Nicoss54 Nicoss54 force-pushed the feature/stepper-input-type-number branch from 53a9e8c to 55d2181 Compare August 18, 2023 14:45
@simplejason simplejason merged commit 0f3aed5 into NG-ZORRO:master Sep 18, 2023
@Nicoss54 Nicoss54 deleted the feature/stepper-input-type-number branch September 18, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make step-counter optional in nz-input [type=number]
2 participants