Skip to content

feat(module:color-picker): add color-picker component #8013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

OriginRing
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jul 12, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #8013 (258af45) into master (078aaf9) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 91.91%.

❗ Current head 258af45 differs from pull request most recent head 7bd7fa5. Consider uploading reports for the commit 7bd7fa5 to get more accurate results

@@            Coverage Diff             @@
##           master    #8013      +/-   ##
==========================================
+ Coverage   91.65%   91.68%   +0.03%     
==========================================
  Files         515      519       +4     
  Lines       17641    17776     +135     
  Branches     2790     2808      +18     
==========================================
+ Hits        16168    16298     +130     
- Misses       1175     1177       +2     
- Partials      298      301       +3     
Files Changed Coverage Δ
components/tree/tree-node.component.ts 92.43% <ø> (+0.49%) ⬆️
components/color-picker/color-format.component.ts 89.79% <89.79%> (ø)
components/color-picker/color-picker.component.ts 92.59% <92.59%> (ø)
components/color-picker/color-block.component.ts 100.00% <100.00%> (ø)
components/color-picker/color-picker.module.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@OriginRing OriginRing changed the title WIP feat(module:color-picker): add color-picker component feat(module:color-picker): add color-picker component Aug 1, 2023
@OriginRing OriginRing force-pushed the feat/color-picker branch 3 times, most recently from c0c69f2 to c740c66 Compare August 8, 2023 08:04
@OriginRing
Copy link
Collaborator Author

其中依赖的ng-antd-color-picker 是 rc-component/color-picker angular版的实现

@Laffery
Copy link
Collaborator

Laffery commented Sep 4, 2023

  • demo 的描述文案需要更新下(「最简单的用法」)
    image

  • 以下 demo 的样式需要调整下

image

@simplejason
Copy link
Member

  • demo 的描述文案需要更新下(「最简单的用法」)
    image
  • 以下 demo 的样式需要调整下

image

单独fix,可以先合并

@simplejason simplejason merged commit 8439704 into NG-ZORRO:master Sep 18, 2023
@OriginRing OriginRing deleted the feat/color-picker branch March 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants