Skip to content

fix(module:table): remove empty space in custom columns #8022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix(module:table): remove empty space in custom columns #8022

merged 1 commit into from
Sep 12, 2023

Conversation

vmural
Copy link
Contributor

@vmural vmural commented Jul 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

https://stackblitz.com/edit/angular-z9xssu

Issue Number: N/A

What is the new behavior?

When using custom fixed-width columns, empty space appears between columns if the total width of the columns is less than the width of the table

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vmural vmural requested a review from vthinkxie as a code owner July 19, 2023 13:24
@zorro-bot
Copy link

zorro-bot bot commented Jul 19, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #8022 (ee32301) into master (078aaf9) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head ee32301 differs from pull request most recent head 76eb95f. Consider uploading reports for the commit 76eb95f to get more accurate results

@@            Coverage Diff             @@
##           master    #8022      +/-   ##
==========================================
+ Coverage   91.65%   91.66%   +0.01%     
==========================================
  Files         515      515              
  Lines       17641    17641              
  Branches     2790     2790              
==========================================
+ Hits        16168    16170       +2     
+ Misses       1175     1174       -1     
+ Partials      298      297       -1     
Impacted Files Coverage Δ
...mponents/table/src/cell/custom-column.directive.ts 89.47% <0.00%> (ø)

... and 1 file with indirect coverage changes

@simplejason simplejason merged commit 15e244c into NG-ZORRO:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants