-
Notifications
You must be signed in to change notification settings - Fork 4k
perf(module:select): ability to pass key | nzKey to select option #8033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(module:select): ability to pass key | nzKey to select option #8033
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #8033 +/- ##
==========================================
- Coverage 91.64% 91.64% -0.01%
==========================================
Files 515 515
Lines 17637 17642 +5
Branches 2789 2792 +3
==========================================
+ Hits 16164 16168 +4
+ Misses 1175 1174 -1
- Partials 298 300 +2
|
@vthinkxie pls review once you will be able, thx) |
@hsuanxyz Hi, maybe you can review? thx) |
@simplejason check this plz. |
@oleksandr-codefresh can we change the commit type to |
When object is used as key for select option re-rendering occurs, to solve this added new 'key' param | 'nzKey' Input
5f8b23d
to
bc4cf48
Compare
@hsuanxyz yes, changed it |
@simplejason @vthinkxie @hsuanxyz pls, review when it's possible for you 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@OriginRing Hi, could you pls add label 'PR: reviewed-approved' to pr? |
When 'object' is used as 'value' for select option re-rendering occurs each time data comes, to solve this added new 'key' param | 'nzKey' Input
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Under the hood nz-select uses value | nzValue as key for rendering optimizations. In case if value of 'object' type this doesn't work well.
Issue Number: #8034
What is the new behavior?
We use value as fallback and allow passing key | nzKey for this specific purpose
Does this PR introduce a breaking change?
Other information