fix(module:tree-view): re-rendering fix for virtual-scroll-view#8035
Merged
simplejason merged 1 commit intoNG-ZORRO:masterfrom Sep 12, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8035 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 515 515
Lines 17640 17640
Branches 2790 2790
=======================================
Hits 16167 16167
Misses 1175 1175
Partials 298 298 |
[ node.ts ]: 'hasContextShapeChanged' func previously didn't allow customization of how to compare data objects, now it will use treeControl.trackBy func to do it in proper and optimized way
5954e76 to
6fe9ea1
Compare
Contributor
Author
|
@hsuanxyz Hi, pls review once it will be possible, thx) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
node.ts / hasContextShapeChangedfunction previously didn't allow customisation of how to compare data objects and did that by simple object link comparison.Issue Number: N/A
What is the new behavior?
Now it will use treeControl.trackBy function to extract concreate
keyfield from object (as user defined) and do it in proper and optimised wayDoes this PR introduce a breaking change?
Other information