Skip to content

fix(module:table): custom column styles collapse when using nzScroll #8044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

OriginRing
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@OriginRing OriginRing requested a review from vthinkxie as a code owner August 3, 2023 03:22
@zorro-bot
Copy link

zorro-bot bot commented Aug 3, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5834e46) 91.68% compared to head (15836fd) 91.70%.

❗ Current head 15836fd differs from pull request most recent head bfcab6e. Consider uploading reports for the commit bfcab6e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8044      +/-   ##
==========================================
+ Coverage   91.68%   91.70%   +0.01%     
==========================================
  Files         519      519              
  Lines       17857    17857              
  Branches     2735     2735              
==========================================
+ Hits        16373    16375       +2     
+ Misses       1185     1184       -1     
+ Partials      299      298       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simplejason
Copy link
Member

Need to move changes to patch.less

@OriginRing OriginRing merged commit fde48f9 into NG-ZORRO:master Nov 17, 2023
@OriginRing OriginRing deleted the fix/table-custom branch March 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After using NzCustomColumn and fixed column configuration, nz-table style crashed
2 participants