Skip to content

feat(module:cascader): support for load options with observable #8048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

HyperLife1119
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Aug 8, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #8048 (50f4ccc) into master (fa0312a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 50f4ccc differs from pull request most recent head b2dd8c8. Consider uploading reports for the commit b2dd8c8 to get more accurate results

@@           Coverage Diff           @@
##           master    #8048   +/-   ##
=======================================
  Coverage   91.64%   91.65%           
=======================================
  Files         515      515           
  Lines       17640    17637    -3     
  Branches     2790     2788    -2     
=======================================
- Hits        16167    16166    -1     
+ Misses       1175     1173    -2     
  Partials      298      298           
Files Changed Coverage Δ
components/cascader/cascader.component.ts 97.94% <ø> (ø)
components/cascader/typings.ts 100.00% <ø> (ø)
components/cascader/cascader.service.ts 100.00% <100.00%> (+0.48%) ⬆️

... and 1 file with indirect coverage changes

@simplejason simplejason merged commit 1436f21 into NG-ZORRO:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants