Skip to content

fix(module:menu): ellipsis menu title content if overflow #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Aug 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8051

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@Laffery Laffery requested a review from vthinkxie as a code owner August 15, 2023 04:40
@zorro-bot
Copy link

zorro-bot bot commented Aug 15, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #8055 (5a95a98) into master (24961cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5a95a98 differs from pull request most recent head 9996520. Consider uploading reports for the commit 9996520 to get more accurate results

@@           Coverage Diff           @@
##           master    #8055   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files         518      518           
  Lines       17786    17786           
  Branches     2808     2808           
=======================================
+ Hits        16303    16304    +1     
+ Misses       1181     1180    -1     
  Partials      302      302           
Files Changed Coverage Δ
components/menu/menu.module.ts 100.00% <ø> (ø)
components/menu/submenu-title.component.ts 100.00% <ø> (ø)
components/menu/menu-item.component.ts 77.94% <100.00%> (ø)
components/menu/menu.directive.ts 93.93% <100.00%> (ø)
components/menu/submenu.component.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Laffery Laffery requested a review from OriginRing September 1, 2023 03:33
@Laffery Laffery requested a review from simplejason September 18, 2023 03:28
@OriginRing OriginRing merged commit 0674f78 into NG-ZORRO:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants