Skip to content

fix(showcase): ui bug in rtl mode inside the doc site #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ParsaArvanehPA
Copy link
Contributor

@ParsaArvanehPA ParsaArvanehPA commented Aug 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[✔] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Go to the current document site , follow these steps to reproduce the bug:

  • click on the RTL button in the header
  • start minimizing your window until you reach 993px
  • when entering 992px, you will see that although the affix is gone, the main container doesn't take up the freed space

What is the new behavior?

The problem was with the specificity of CSS rules, with that corrected now when you reach the specified media query size, the main container will reduce its padding so that it can take up the space left behind by the said affix.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #8063 (bfe0059) into master (7f7c155) will not change coverage.
The diff coverage is n/a.

❗ Current head bfe0059 differs from pull request most recent head 9f7c307. Consider uploading reports for the commit 9f7c307 to get more accurate results

@@           Coverage Diff           @@
##           master    #8063   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         515      515           
  Lines       17640    17640           
  Branches     2790     2790           
=======================================
  Hits        16167    16167           
  Misses       1175     1175           
  Partials      298      298           

@simplejason simplejason merged commit d57b7da into NG-ZORRO:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants