fix(module:drawer): remove inline style to resolve CSP issue#8065
fix(module:drawer): remove inline style to resolve CSP issue#8065HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8065 +/- ##
==========================================
- Coverage 91.74% 91.61% -0.14%
==========================================
Files 520 530 +10
Lines 18023 18391 +368
Branches 2838 2815 -23
==========================================
+ Hits 16536 16849 +313
- Misses 1184 1225 +41
- Partials 303 317 +14 ☔ View full report in Codecov by Sentry. |
4c8227c to
890122e
Compare
890122e to
8346dfe
Compare
|
We should remove |
8346dfe to
5d185b0
Compare
Updated. |
Nicoss54
left a comment
There was a problem hiding this comment.
Thanks for the work, is it possible to make pass the job failed please ?
After that LGTM
| aria-label="Close" | ||
| class="ant-drawer-close" | ||
| style="--scroll-bar: 0px;" | ||
| [style.--scroll-bar]="'0px' |
There was a problem hiding this comment.
suggestion: it seems it miss the ". I think that's why the build and test job in the pipeline failed. Maybe
[style.--scroll-bar]="'0px'"will be more correct
There was a problem hiding this comment.
Oh, that's a prettier formatting error.
It seems that there are still some problems with zorro's lint-staged. You now need to manually run prettier --fix to format the file. @arturovt
5d185b0 to
cdac11b
Compare
No description provided.