Skip to content

fix(module:tree-select): 修复节点为禁用状态时,back快捷键能删除bug #8105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

EnochGao
Copy link
Contributor

@EnochGao EnochGao commented Oct 8, 2023

修复,当节点为禁用状态时,通过快捷键能删除禁用状态节点问题

@EnochGao EnochGao requested a review from hsuanxyz as a code owner October 8, 2023 08:32
@zorro-bot
Copy link

zorro-bot bot commented Oct 8, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #8105 (59b6302) into master (a4b299e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 59b6302 differs from pull request most recent head 927bee9. Consider uploading reports for the commit 927bee9 to get more accurate results

@@           Coverage Diff           @@
##           master    #8105   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         518      518           
  Lines       17786    17788    +2     
  Branches     2719     2721    +2     
=======================================
+ Hits        16306    16308    +2     
  Misses       1179     1179           
  Partials      301      301           
Files Coverage Δ
components/tree-select/tree-select.component.ts 91.38% <100.00%> (+0.06%) ⬆️

@EnochGao
Copy link
Contributor Author

EnochGao commented Oct 8, 2023

通过键盘back,10011 节点不应该被删除
bug demo

@HyperLife1119
Copy link
Collaborator

你可以将 commit message 修正为 fix(module:tree-select): ... 吗?

@EnochGao EnochGao changed the title fix: 修复节点为禁用状态时,back快捷键能删除bug fix(module:tree-select): 修复节点为禁用状态时,back快捷键能删除bug Oct 15, 2023
@OriginRing OriginRing merged commit 07a1f5e into NG-ZORRO:master Oct 19, 2023
@EnochGao EnochGao deleted the fix-tree-select branch October 20, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants