Skip to content

fix: inline cdk-overlay style #8132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Oct 20, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8131

What is the new behavior?

This question is similar to angular/angular-cli#12981 , importing lib.css in a relative directory will cause some problems.

No better solution has been found yet. This modification will use the past method of manually inlining the overlay style.

We should merge it as soon as possible and release a patch version.

@OriginRing @Nicoss54

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 20, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #8132 (b8d430a) into master (a664db7) will increase coverage by 1.52%.
The diff coverage is n/a.

❗ Current head b8d430a differs from pull request most recent head e5bfcbb. Consider uploading reports for the commit e5bfcbb to get more accurate results

@@            Coverage Diff             @@
##           master    #8132      +/-   ##
==========================================
+ Coverage   91.66%   93.18%   +1.52%     
==========================================
  Files         518      518              
  Lines       17796    17796              
  Branches     2724     2724              
==========================================
+ Hits        16313    16584     +271     
+ Misses       1180     1179       -1     
+ Partials      303       33     -270     

see 107 files with indirect coverage changes

@Nicoss54
Copy link
Collaborator

@OriginRing this is a fix for a critical issue. I merge it and it really important to make a release patch fast since currently the library doesn’t work

@Nicoss54 Nicoss54 merged commit 3209d74 into NG-ZORRO:master Oct 21, 2023
@OriginRing
Copy link
Collaborator

OriginRing commented Oct 21, 2023

@Nicoss54 I will post it in the next two days (16.2.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants