Skip to content

fix(module:form): ui bug when clicking a label in forms document #8135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

ParsaArvanehPA
Copy link
Contributor

@ParsaArvanehPA ParsaArvanehPA commented Oct 23, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[✔] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Clicking of this label, would focus on a wrong input.

image

Issue Number: N/A

What is the new behavior?

The reason for this behavior is that there are more than one elements with id: password. Just changed the second id to a unique value fixed this behavior. Now when that label id clicked, the input box in front of it is focused.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 23, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #8135 (fb34704) into master (7f7c155) will increase coverage by 1.53%.
Report is 38 commits behind head on master.
The diff coverage is 92.88%.

❗ Current head fb34704 differs from pull request most recent head 17103eb. Consider uploading reports for the commit 17103eb to get more accurate results

@@            Coverage Diff             @@
##           master    #8135      +/-   ##
==========================================
+ Coverage   91.64%   93.18%   +1.53%     
==========================================
  Files         515      517       +2     
  Lines       17640    17795     +155     
  Branches     2790     2724      -66     
==========================================
+ Hits        16167    16582     +415     
- Misses       1175     1180       +5     
+ Partials      298       33     -265     
Files Coverage Δ
components/breadcrumb/breadcrumb-item.component.ts 100.00% <ø> (ø)
...nents/breadcrumb/breadcrumb-separator.component.ts 100.00% <ø> (ø)
components/button/button.component.ts 100.00% <100.00%> (+2.56%) ⬆️
components/cascader/cascader.component.ts 98.45% <ø> (+0.51%) ⬆️
components/cascader/cascader.service.ts 100.00% <100.00%> (+0.48%) ⬆️
components/cascader/typings.ts 100.00% <ø> (ø)
components/color-picker/color-block.component.ts 100.00% <100.00%> (ø)
components/color-picker/color-picker.module.ts 100.00% <100.00%> (ø)
components/core/config/config.service.ts 100.00% <100.00%> (ø)
components/core/config/config.ts 100.00% <100.00%> (ø)
... and 32 more

... and 95 files with indirect coverage changes

@OriginRing
Copy link
Collaborator

please correct the commit message to fix(module:form): ······

@ParsaArvanehPA ParsaArvanehPA force-pushed the bug/form-incorrect-focus branch from 04d41fa to 17103eb Compare October 24, 2023 09:52
@ParsaArvanehPA ParsaArvanehPA changed the title fix(showcase): ui bug when clicking a label in forms document fix(module:form): ui bug when clicking a label in forms document Oct 24, 2023
@OriginRing OriginRing merged commit b3d135f into NG-ZORRO:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants