fix(module:mention): page not loading entirely #8146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently when you navigate to mention component, you'll notice that mention page does not load at all. This behaviour is caused by a logical error in
form.ts
.At line number 54,
this.mentionChild
is equal toundefined
. I just added an optional chain so if it is undefined it won't throw an error.Issue Number: N/A
What is the new behavior?
Mention page can now be loaded and viewed, and
form.ts
has the same functionality as intended (checked with version 15 of ng-zorro).Does this PR introduce a breaking change?
Other information
Image of
mention component
not working: