Skip to content

fix(module:mention): page not loading entirely #8146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[✔] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently when you navigate to mention component, you'll notice that mention page does not load at all. This behaviour is caused by a logical error in form.ts.
At line number 54, this.mentionChild is equal to undefined. I just added an optional chain so if it is undefined it won't throw an error.

Issue Number: N/A

What is the new behavior?

Mention page can now be loaded and viewed, and form.ts has the same functionality as intended (checked with version 15 of ng-zorro).

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Image of mention component not working:

image

Copy link

zorro-bot bot commented Nov 4, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #8146 (63414af) into master (50f6700) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 63414af differs from pull request most recent head 16bc62c. Consider uploading reports for the commit 16bc62c to get more accurate results

@@            Coverage Diff             @@
##           master    #8146      +/-   ##
==========================================
- Coverage   91.69%   91.69%   -0.01%     
==========================================
  Files         517      517              
  Lines       17795    17795              
  Branches     2724     2724              
==========================================
- Hits        16318    16317       -1     
- Misses       1178     1179       +1     
  Partials      299      299              

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants