Skip to content

Conversation

@HyperLife1119
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

#8042 (comment)

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 18, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9505c7c) 91.69% compared to head (d521f19) 91.68%.
Report is 18 commits behind head on master.

Files Patch % Lines
components/resizable/resize-handle.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8169      +/-   ##
==========================================
- Coverage   91.69%   91.68%   -0.02%     
==========================================
  Files         517      519       +2     
  Lines       17795    17857      +62     
  Branches     2724     2735      +11     
==========================================
+ Hits        16318    16373      +55     
- Misses       1178     1185       +7     
  Partials      299      299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit a0b8a0b into NG-ZORRO:master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants