feat(module:water-mark): nzWaterMark is a block element && standalone #8197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
OriginRing
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8197 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 519 519
Lines 17887 17887
Branches 2836 2836
=======================================
Hits 16403 16403
Misses 1182 1182
Partials 302 302 ☔ View full report in Codecov by Sentry. |
| @@ -120,7 +122,8 @@ export class NzWaterMarkComponent implements AfterViewInit, OnInit, OnChanges, O | |||
| width: '100%', | |||
| height: '100%', | |||
| pointerEvents: 'none', | |||
| backgroundRepeat: 'repeat' | |||
| backgroundRepeat: 'repeat', | |||
| visibility: 'visible !important' | |||
There was a problem hiding this comment.
我们可以避免使用 !important 吗？
| @@ -30,6 +30,8 @@ const FontGap = 3; | |||
|
|
|||
| @Component({ | |||
| selector: 'nz-water-mark', | |||
| standalone: true, | |||
| imports: [CommonModule], | |||
There was a problem hiding this comment.
看起来我们并没有使用到 CommonModule，我们可以删除它 :)
OriginRing
force-pushed
the
fix/watermark-div
branch
from
743c2f9 to
cbc9265
Compare
HyperLife1119
approved these changes
Nov 28, 2023
OriginRing
force-pushed
the
fix/watermark-div
branch
from
cbc9265 to
4f13fe1
Compare
LGTM too. |
HyperLife1119
added
PR: reviewed-approved
PR: target-minor
PR: target-major
and removed
PR: target-minor
PR: target-major
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #8187
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information