Skip to content

feat(module:time-picker): support standalone component#8211

Merged
Nicoss54 merged 6 commits intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/time-picker-component-support-standalone
Dec 7, 2023
Merged

feat(module:time-picker): support standalone component#8211
Nicoss54 merged 6 commits intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/time-picker-component-support-standalone

Conversation

@ParsaArvanehPA
Copy link
Contributor

@ParsaArvanehPA ParsaArvanehPA commented Nov 30, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

Updated Time picker component to work as a standalone component.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 30, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a7cd50) 91.72% compared to head (c300e54) 91.70%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8211      +/-   ##
==========================================
- Coverage   91.72%   91.70%   -0.02%     
==========================================
  Files         520      520              
  Lines       17905    17905              
  Branches     2839     2839              
==========================================
- Hits        16423    16420       -3     
- Misses       1180     1182       +2     
- Partials      302      303       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the pipeline pass. For now build and test failed

@Nicoss54 Nicoss54 added PR: unreviewed and removed 🤚 Blocked PR: need-test Test is necessary for code changes. labels Dec 5, 2023
@ParsaArvanehPA
Copy link
Contributor Author

Please make the pipeline pass. For now build and test failed

Requested changes have been made, currently both test and build pipes pass. Let me know if any more changes are needed

@Nicoss54 Nicoss54 merged commit 641ebb2 into NG-ZORRO:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants