Skip to content

feat(module:pagination): support standalone component#8234

Merged
Nicoss54 merged 1 commit into
NG-ZORRO:masterfrom
ParsaArvanehPA:feature/pagination-component-support-standalone
Dec 4, 2023
Merged

feat(module:pagination): support standalone component#8234
Nicoss54 merged 1 commit into
NG-ZORRO:masterfrom
ParsaArvanehPA:feature/pagination-component-support-standalone

Conversation

@ParsaArvanehPA

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

Updated Pagination component to work as a standalone component.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@zorro-bot

zorro-bot Bot commented Nov 30, 2023

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Nov 30, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fd0b31) 91.70% compared to head (d5be69a) 92.51%.
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8234      +/-   ##
==========================================
+ Coverage   91.70%   92.51%   +0.81%     
==========================================
  Files         519      519              
  Lines       17887    19958    +2071     
  Branches     2836     3484     +648     
==========================================
+ Hits        16403    18464    +2061     
- Misses       1182     1193      +11     
+ Partials      302      301       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nicoss54

Nicoss54 commented Dec 2, 2023

Copy link
Copy Markdown
Collaborator

@ParsaArvanehPA test failed, could you fix it please ?

After that LGTM

@Nicoss54

Nicoss54 commented Dec 2, 2023

Copy link
Copy Markdown
Collaborator

@ParsaArvanehPA test failed, could you fix it please ?

After that LGTM

@ParsaArvanehPA i lauched again and it's okey. Your changes had'nt no impacts on the test failed

@Nicoss54
Nicoss54 self-requested a review December 2, 2023 15:59
@ParsaArvanehPA

Copy link
Copy Markdown
Contributor Author

@ParsaArvanehPA test failed, could you fix it please ?
After that LGTM

@ParsaArvanehPA i lauched again and it's okey. Your changes had'nt no impacts on the test failed

Sorry for the delay,
Thanks.
Yeah oddly all the failed prs(except 2 of them), have a problem with npm.
I'll fix them and get back to you. @Nicoss54

@Nicoss54
Nicoss54 merged commit 0f1690c into NG-ZORRO:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants