Skip to content

feat(module:notification): support standalone component#8236

Merged
OriginRing merged 1 commit intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/notification-component-support-standalone
Dec 1, 2023
Merged

feat(module:notification): support standalone component#8236
OriginRing merged 1 commit intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/notification-component-support-standalone

Conversation

@ParsaArvanehPA
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

Updated Notification component to work as a standalone component.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fd0b31) 91.70% compared to head (362aeb4) 91.71%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8236      +/-   ##
==========================================
+ Coverage   91.70%   91.71%   +0.01%     
==========================================
  Files         519      518       -1     
  Lines       17887    17886       -1     
  Branches     2836     2836              
==========================================
+ Hits        16403    16404       +1     
+ Misses       1182     1181       -1     
+ Partials      302      301       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OriginRing OriginRing merged commit 686b6b0 into NG-ZORRO:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants