feat(module:date-picker): support standalone component#8263
Merged
Nicoss54 merged 4 commits intoNG-ZORRO:masterfrom Dec 11, 2023
Merged
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8263 +/- ##
==========================================
- Coverage 91.71% 91.70% -0.01%
==========================================
Files 518 520 +2
Lines 17887 17898 +11
Branches 2837 2838 +1
==========================================
+ Hits 16405 16414 +9
Misses 1181 1181
- Partials 301 303 +2 ☔ View full report in Codecov by Sentry. |
Nicoss54
requested changes
Dec 4, 2023
Collaborator
Nicoss54
left a comment
There was a problem hiding this comment.
Please make the build pass
Collaborator
|
Let's delete the BidiModule again :) |
Contributor
Author
Sure, I will get back to you as soon as I can :) |
Contributor
Author
Changes have been made |
Nicoss54
approved these changes
Dec 11, 2023
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Updated Date picker component to work as a standalone component.
Does this PR introduce a breaking change?
Other information