Skip to content

feat(module:date-picker): support standalone component#8263

Merged
Nicoss54 merged 4 commits intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/date-picker-component-support-standalone
Dec 11, 2023
Merged

feat(module:date-picker): support standalone component#8263
Nicoss54 merged 4 commits intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/date-picker-component-support-standalone

Conversation

@ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

Updated Date picker component to work as a standalone component.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 2, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (165f171) 91.71% compared to head (6a4e766) 91.70%.
Report is 47 commits behind head on master.

Files Patch % Lines
components/date-picker/lib/abstract-table.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8263      +/-   ##
==========================================
- Coverage   91.71%   91.70%   -0.01%     
==========================================
  Files         518      520       +2     
  Lines       17887    17898      +11     
  Branches     2837     2838       +1     
==========================================
+ Hits        16405    16414       +9     
  Misses       1181     1181              
- Partials      301      303       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the build pass

@HyperLife1119
Copy link
Collaborator

Let's delete the BidiModule again :)

#8229 (comment)

@ParsaArvanehPA
Copy link
Contributor Author

Let's delete the BidiModule again :)

#8229 (comment)

Sure, I will get back to you as soon as I can :)

@ParsaArvanehPA
Copy link
Contributor Author

Let's delete the BidiModule again :)

#8229 (comment)

Changes have been made

@Nicoss54 Nicoss54 self-requested a review December 7, 2023 18:05
@Nicoss54
Copy link
Collaborator

LGTM

@Nicoss54 Nicoss54 merged commit ac48fba into NG-ZORRO:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants