Skip to content

fix(module:carousel): not adapting to new size when resizing#8374

Merged
OriginRing merged 3 commits intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/carousel-not-changing-when-resized
Mar 11, 2024
Merged

fix(module:carousel): not adapting to new size when resizing#8374
OriginRing merged 3 commits intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/carousel-not-changing-when-resized

Conversation

@ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[✔] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Carousel component currently does not adapt to the new size when it is resized.

Issue Number: #8359

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

I have set a 100ms delay for the the debounceTime, so the this.layout() method does not fire so often; but I am not sure as to what is the best value for dueTime of debounceTime.

@zorro-bot
Copy link

zorro-bot bot commented Jan 28, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6024bcc) 91.74% compared to head (6231f04) 91.75%.
Report is 21 commits behind head on master.

Files Patch % Lines
components/carousel/carousel.component.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8374      +/-   ##
==========================================
+ Coverage   91.74%   91.75%   +0.01%     
==========================================
  Files         520      519       -1     
  Lines       18019    18030      +11     
  Branches     2838     2838              
==========================================
+ Hits        16531    16543      +12     
  Misses       1185     1185              
+ Partials      303      302       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you provide test for the code you added ?

@ParsaArvanehPA
Copy link
Contributor Author

Please could you provide test for the code you added ?

Sure, I will get back to you with that as soon as I can.

@ParsaArvanehPA
Copy link
Contributor Author

Please could you provide test for the code you added ?

Sorry for the delay; tests for the changes have been added.
Thank you for reviewing my PRs @Nicoss54

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OriginRing OriginRing merged commit 6e1decb into NG-ZORRO:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants