fix(module:carousel): not adapting to new size when resizing#8374
Merged
OriginRing merged 3 commits intoNG-ZORRO:masterfrom Mar 11, 2024
Merged
Conversation
|
This preview will be available after the AzureCI is passed. |
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8374 +/- ##
==========================================
+ Coverage 91.74% 91.75% +0.01%
==========================================
Files 520 519 -1
Lines 18019 18030 +11
Branches 2838 2838
==========================================
+ Hits 16531 16543 +12
Misses 1185 1185
+ Partials 303 302 -1 ☔ View full report in Codecov by Sentry. |
Nicoss54
requested changes
Jan 29, 2024
Collaborator
Nicoss54
left a comment
There was a problem hiding this comment.
Please could you provide test for the code you added ?
Contributor
Author
Sure, I will get back to you with that as soon as I can. |
Contributor
Author
Sorry for the delay; tests for the changes have been added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Carousel component currently does not adapt to the new size when it is resized.
Issue Number: #8359
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I have set a 100ms delay for the the debounceTime, so the
this.layout()method does not fire so often; but I am not sure as to what is the best value for dueTime of debounceTime.