feat(module:modal): expose componentRef nzContent#8389
Merged
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom Feb 8, 2024
Merged
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8389 +/- ##
=======================================
Coverage 91.74% 91.75%
=======================================
Files 520 520
Lines 18023 18028 +5
Branches 2838 2838
=======================================
+ Hits 16535 16541 +6
+ Misses 1185 1184 -1
Partials 303 303 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Can you add Chinese documentation? :D |
Collaborator
Author
I'm sorry i don't speak chinese, but if you can give me the translation i will add it :) |
Collaborator
Contributor
Ok, I will translate after the merger is successful. ^o^ |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently modalRef don't expose the componentRef of nzContent which is too restricted. With the new API of Angular, user must have he possibilities to retrieve the ref of the component of nzContent to use for exemple APIs like setInput
Issue Number: N/A
What is the new behavior?
Now ModalRef expose the component Ref of the nzContent when nzContent is a component. This exposition is done by the mehtod getComponentRef which return the ref in a readonly mode
Does this PR introduce a breaking change?
Other information