Skip to content

Conversation

@HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Feb 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Replace provideAnimations and AnimationsModule with provideAnimationsAsync.
  • Replace HttpClientModule with provideHttpClient.
  • Referenced @angular/material to remove the logic that determines if AnimationsModule have been added.

It also removes some deprecated function calls, such as: addFunctionalProvidersToStandaloneBootstrap.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

https://github.com/angular/components/blob/facd027f5f05828d108bccefdd0df68cd4583904/src/material/schematics/ng-add/setup-project.ts#L24-L53

@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be3366e) 91.61% compared to head (84a1900) 91.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8411   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         519      519           
  Lines       18076    18076           
  Branches     2848     2848           
=======================================
  Hits        16561    16561           
  Misses       1216     1216           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54 Nicoss54 merged commit 921f1c1 into NG-ZORRO:master Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants