fix(module:list): remove NgZone dependency #8439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `NgZone` dependency from the list item cell. With zone.js becoming optional, `onStable` won't emit any value when `provideZonelessChangeDetection` is used in the application config. Instead, it now listens to a subject emission when the content projection has been initialized.
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8439 +/- ##
==========================================
- Coverage 91.61% 91.61% -0.01%
==========================================
Files 530 530
Lines 18391 18389 -2
Branches 2815 2815
==========================================
- Hits 16849 16847 -2
Misses 1225 1225
Partials 317 317 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
NgZonedependency from the list item cell. With zone.js becoming optional,onStablewon't emit any value whenprovideZonelessChangeDetectionis used in the application config. Instead, it now listens to a subject emission when the content projection has been initialized.