feat(module:rate): emit hover change when leave

[Nicoss54]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently when the rate is left no event emitter is sent. This prevent customisation like changing icon

Issue Number: #8415

What is the new behavior?

hoverChange event is now sent when the user left the rate

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

[zorro-bot]

This preview will be available after the AzureCI is passed.

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (116346f) to head (2ea061d).
Report is 78 commits behind head on master.

Files	Patch %	Lines
components/rate/rate.component.ts	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8448      +/-   ##
==========================================
- Coverage   91.62%   91.60%   -0.02%     
==========================================
  Files         530      531       +1     
  Lines       18390    18400      +10     
  Branches     2815     2814       -1     
==========================================
+ Hits        16849    16855       +6     
- Misses       1225     1228       +3     
- Partials      316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HyperLife1119]

I think it's a bug that OnHoverChange event is not triggered when the rate value is unchanged. In this case, we still need to trigger OnHoverChange event.
Let's fix it here :)

ng-zorro-antd/components/rate/rate.component.ts

Lines 222 to 232 in 116346f

	onItemHover(index: number, isHalf: boolean): void {
	if (this.nzDisabled || (this.hoverValue === index + 1 && isHalf === this.hasHalf)) {
	return;
	}
	this.hoverValue = index + 1;
	this.hasHalf = isHalf;
	this.nzOnHoverChange.emit(this.hoverValue);
	this.updateStarStyle();
	}

[Nicoss54]

I think it's a bug that OnHoverChange event is not triggered when the rate value is unchanged. In this case, we still need to trigger OnHoverChange event. Let's fix it here :)

ng-zorro-antd/components/rate/rate.component.ts

Lines 222 to 232 in 116346f

	onItemHover(index: number, isHalf: boolean): void {
	if (this.nzDisabled || (this.hoverValue === index + 1 && isHalf === this.hasHalf)) {
	return;
	}
	this.hoverValue = index + 1;
	this.hasHalf = isHalf;
	this.nzOnHoverChange.emit(this.hoverValue);
	this.updateStarStyle();
	}

@HyperLife1119 it's done. Thanks again for the review

[HyperLife1119]

If the state is disabled, the event should not be triggered.

[Nicoss54]

done

[HyperLife1119]

I think the logic here would be this :) WDYT?

  onItemHover(index: number, isHalf: boolean): void {
    if (this.nzDisabled) {
      return;
    }

    if (this.hoverValue !== index + 1 || isHalf !== this.hasHalf) {
      this.hoverValue = index + 1;
      this.hasHalf = isHalf;
      this.updateStarStyle();
    }

    this.nzOnHoverChange.emit(this.hoverValue);
  }

[Nicoss54]

Hi, I'm not against this proposal quite the contrary :), but if we do that we break the current behavior of the component isn't it ? Maybe we could do a little RFC ?

[HyperLife1119]

https://stackblitz.com/edit/react-efsuqc?file=demo.tsx

Based on my observations of the behavior of the antd rate component, I think this is a bug fix.
If it is a breaking change, we need to merge it in the next major release.
WDYT?

[Nicoss54]

@HyperLife1119 after investigation on my side you're right, so i made the change :). Thanks for your time and help

[HyperLife1119]

Oh, I think you're missing some details:

• When disabled, events are not triggered.
• The event still needs to be triggered even if the rate value has not changed.

I think it's supposed to work like this:

  onItemHover(index: number, isHalf: boolean): void {
    if (this.nzDisabled) {
      return;
    }

    if (this.hoverValue !== index + 1 || isHalf !== this.hasHalf) {
      this.hoverValue = index + 1;
      this.hasHalf = isHalf;
      this.updateStarStyle();
    }

    this.nzOnHoverChange.emit(this.hoverValue);
  }

[Nicoss54]

@HyperLife1119 change done

[HyperLife1119]

Great job, Nicoss :)

[HyperLife1119]

LGTM.
@OriginRing WDYT?

[Laffery]

LGTM