Skip to content

Conversation

@OriginRing
Copy link
Collaborator

@OriginRing OriginRing commented Mar 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 20, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.62%. Comparing base (9744740) to head (13fe982).
Report is 4 commits behind head on master.

Files Patch % Lines
...s/notification/notification-container.component.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8450      +/-   ##
==========================================
+ Coverage   91.61%   91.62%   +0.01%     
==========================================
  Files         530      530              
  Lines       18391    18390       -1     
  Branches     2815     2815              
==========================================
+ Hits        16849    16850       +1     
+ Misses       1225     1224       -1     
+ Partials      317      316       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Copy link
Collaborator

Laffery commented Apr 17, 2024

@OriginRing LGTM too, 关注下 codecov 覆盖率的变化

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants