Skip to content

Conversation

@ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Not possible to pass the no data virtual height.
Typo fixed: noDateVirtualHeight => noDataVirtualHeight

Issue Number: #8446

What is the new behavior?

Described in the issue #8446

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 20, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (169f678) to head (c254dba).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8457      +/-   ##
==========================================
- Coverage   91.60%   91.59%   -0.02%     
==========================================
  Files         535      535              
  Lines       18428    18429       +1     
  Branches     2817     2817              
==========================================
- Hits        16881    16880       -1     
- Misses       1229     1230       +1     
- Partials      318      319       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery changed the title feat(module:table): no data virtual height feat(module:table): support setting virtual height when having no data Jun 2, 2024
@Laffery Laffery merged commit 724d841 into NG-ZORRO:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants