feat(module:menu): add click trigger for submenus#8461
feat(module:menu): add click trigger for submenus#8461Laffery merged 25 commits intoNG-ZORRO:masterfrom
Conversation
…vanehPA/ng-zorro-antd into feature/submenu-triggers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8461 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 543 543
Lines 19181 19185 +4
Branches 2828 2828
=======================================
+ Hits 17624 17628 +4
Misses 1245 1245
Partials 312 312 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
your requested changes are made, could you please check it once more |
|
Hey guys |
Laffery
left a comment
There was a problem hiding this comment.
LGTM
BTW, I think the API shoud be named nzSubmenuTrigger, I will add a commit to change it
Alright, ant-design use |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In Ant design, it is possible to choose between a
clickor ahovertrigger for submenues.Issue Number: #4745
What is the new behavior?
clicktrigger implemented.Does this PR introduce a breaking change?
Other information