Skip to content

feat(module:menu): add click trigger for submenus#8461

Merged
Laffery merged 25 commits intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/submenu-triggers
Nov 22, 2024
Merged

feat(module:menu): add click trigger for submenus#8461
Laffery merged 25 commits intoNG-ZORRO:masterfrom
ParsaArvanehPA:feature/submenu-triggers

Conversation

@ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In Ant design, it is possible to choose between a click or a hover trigger for submenues.

Issue Number: #4745

What is the new behavior?

click trigger implemented.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@codecov
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (776fb66) to head (241e860).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8461   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files         543      543           
  Lines       19181    19185    +4     
  Branches     2828     2828           
=======================================
+ Hits        17624    17628    +4     
  Misses       1245     1245           
  Partials      312      312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partially approved

@ParsaArvanehPA
Copy link
Contributor Author

partially approved

your requested changes are made, could you please check it once more

@ParsaArvanehPA ParsaArvanehPA requested a review from Laffery August 4, 2024 10:46
@ParsaArvanehPA
Copy link
Contributor Author

Hey guys
I have some old branches that I want to take care of.
Could you please review this again?
@Laffery
@HyperLife1119
@Nicoss54

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
BTW, I think the API shoud be named nzSubmenuTrigger, I will add a commit to change it

@Laffery
Copy link
Collaborator

Laffery commented Nov 22, 2024

LGTM BTW, I think the API shoud be named nzSubmenuTrigger, I will add a commit to change it

Alright, ant-design use triggerSubMenuAction too

@Laffery Laffery added this to the v19 milestone Nov 22, 2024
@Laffery Laffery merged commit 860df87 into NG-ZORRO:master Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants