fix(module:autocomplete): remove NgZone dependency#8462
Merged
arturovt merged 1 commit intoNG-ZORRO:masterfrom Mar 25, 2024
Merged
fix(module:autocomplete): remove NgZone dependency#8462arturovt merged 1 commit intoNG-ZORRO:masterfrom
arturovt merged 1 commit intoNG-ZORRO:masterfrom
Conversation
This commit eliminates the `NgZone` dependency from the autocomplete component. Since zone.js is becoming optional, `onStable` won't emit any value when `provideZonelessChangeDetection` is used in the application config. Instead, we now use the alternative approach provided by `afterNextRender`. Most of the code that was using `onStable` should be replaced with `afterNextRender`.
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8462 +/- ##
==========================================
- Coverage 91.61% 91.60% -0.02%
==========================================
Files 530 531 +1
Lines 18391 18398 +7
Branches 2813 2813
==========================================
+ Hits 16849 16853 +4
- Misses 1225 1228 +3
Partials 317 317 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit eliminates the
NgZonedependency from the autocomplete component. Since zone.js is becoming optional,onStablewon't emit any value whenprovideZonelessChangeDetectionis used in the application config. Instead, we now use the alternative approach provided byafterNextRender. Most of the code that was usingonStableshould be replaced withafterNextRender.