-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(module:image): wrong next/prev btn in rtl mode #8468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:image): wrong next/prev btn in rtl mode #8468
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8468 +/- ##
==========================================
- Coverage 91.62% 91.60% -0.02%
==========================================
Files 530 531 +1
Lines 18391 18398 +7
Branches 2813 2813
==========================================
+ Hits 16850 16853 +3
- Misses 1225 1228 +3
- Partials 316 317 +1 ☔ View full report in Codecov by Sentry. |
Nicoss54
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In RTL mode, the display of next and prev buttons are not correct.
What is the new behavior?
Fixed.
Does this PR introduce a breaking change?
Other information
I didn't create a
rtl.lessfile to fix this issue because this is also a bug in Ant's version 4 Image component; and since this is our fix and not Ant's, I put the style codes inpatch.lessfile.