Skip to content

Conversation

@ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[✔] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In RTL mode, the display of next and prev buttons are not correct.

What is the new behavior?

Fixed.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

image

I didn't create a rtl.less file to fix this issue because this is also a bug in Ant's version 4 Image component; and since this is our fix and not Ant's, I put the style codes in patch.less file.

@zorro-bot
Copy link

zorro-bot bot commented Mar 25, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (297dbec) to head (053fd32).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8468      +/-   ##
==========================================
- Coverage   91.62%   91.60%   -0.02%     
==========================================
  Files         530      531       +1     
  Lines       18391    18398       +7     
  Branches     2813     2813              
==========================================
+ Hits        16850    16853       +3     
- Misses       1225     1228       +3     
- Partials      316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 886138d into NG-ZORRO:master Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants