Skip to content

feat(module:popconfirm): popconfirm support for nzOkDisabled#8542

Merged
OriginRing merged 2 commits intoNG-ZORRO:masterfrom
J0eMag:feat/popconfirm
May 23, 2024
Merged

feat(module:popconfirm): popconfirm support for nzOkDisabled#8542
OriginRing merged 2 commits intoNG-ZORRO:masterfrom
J0eMag:feat/popconfirm

Conversation

@J0eMag
Copy link
Contributor

@J0eMag J0eMag commented May 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 21, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (db09bf7) to head (365d2b2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8542   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         532      532           
  Lines       18332    18334    +2     
  Branches     2801     2801           
=======================================
+ Hits        16788    16790    +2     
  Misses       1226     1226           
  Partials      318      318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OriginRing
Copy link
Collaborator

LGTM

@J0eMag J0eMag force-pushed the feat/popconfirm branch from 65836f8 to 365d2b2 Compare May 23, 2024 07:53
@OriginRing OriginRing merged commit 8c247db into NG-ZORRO:master May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants