Skip to content

Conversation

@HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Jun 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

https://4x.ant.design/components/collapse-cn/#:~:text=%2D-,expandIconPosition,-%E8%AE%BE%E7%BD%AE%E5%9B%BE%E6%A0%87

What is the new behavior?

Parameter types are aligned with antd.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@HyperLife1119 HyperLife1119 requested a review from vthinkxie as a code owner June 3, 2024 07:40
@zorro-bot
Copy link

zorro-bot bot commented Jun 3, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (f668b87) to head (e33d23b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8561      +/-   ##
==========================================
- Coverage   91.52%   91.51%   -0.02%     
==========================================
  Files         535      535              
  Lines       18424    18424              
  Branches     2814     2814              
==========================================
- Hits        16862    16860       -2     
- Misses       1244     1245       +1     
- Partials      318      319       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 added Component: Collapse 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: unreviewed PR: target-major labels Jun 3, 2024
@HyperLife1119 HyperLife1119 requested a review from Laffery June 3, 2024 07:53
@OriginRing
Copy link
Collaborator

LGTM

@Laffery
Copy link
Collaborator

Laffery commented Jun 3, 2024

document should be updated as well :)

@HyperLife1119
Copy link
Collaborator Author

document should be updated as well :)

done

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery changed the title fix(module:collapse): fix nzExpandIconPosition type feat(module:collapse): change nzExpandIconPosition type from left | right to start | end Jun 4, 2024
@Laffery Laffery merged commit 3ad5674 into NG-ZORRO:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💔 Breaking Change This PR or the solution to this issue would introduce breaking changes Component: Collapse PR: reviewed-approved PR: target-major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants