Skip to content

fix(module:i18n): add scanned field to QRCode fa_IR#8597

Merged
Laffery merged 1 commit intoNG-ZORRO:masterfrom
psychomet:bugfix/qrcode-fa-ir-language
Jun 24, 2024
Merged

fix(module:i18n): add scanned field to QRCode fa_IR#8597
Laffery merged 1 commit intoNG-ZORRO:masterfrom
psychomet:bugfix/qrcode-fa-ir-language

Conversation

@psychomet
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8596

What is the new behavior?

fix type fa_IR like en_US add scanned field to QRCode

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@psychomet psychomet requested a review from wenqi73 as a code owner June 23, 2024 09:36
@zorro-bot
Copy link
Copy Markdown

zorro-bot bot commented Jun 23, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (6bb95c0) to head (a55865a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8597   +/-   ##
=======================================
  Coverage   91.50%   91.51%           
=======================================
  Files         534      534           
  Lines       18425    18425           
  Branches     2905     2905           
=======================================
+ Hits        16860    16861    +1     
  Misses       1244     1244           
+ Partials      321      320    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 9c6e4bf into NG-ZORRO:master Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants