Skip to content

Conversation

@RubenVermeulen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8613

What is the new behavior?

No type error is thrown while compiling.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@RubenVermeulen RubenVermeulen requested a review from wenqi73 as a code owner June 28, 2024 12:41
@zorro-bot
Copy link

zorro-bot bot commented Jun 28, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (9b15717) to head (2d542ec).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8614   +/-   ##
=======================================
  Coverage   91.50%   91.51%           
=======================================
  Files         534      534           
  Lines       18425    18425           
  Branches     2905     2905           
=======================================
+ Hits        16860    16861    +1     
  Misses       1244     1244           
+ Partials      321      320    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 9b69410 into NG-ZORRO:master Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants