Skip to content

fix(module:schematics): import RouterLink#8621

Merged
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
JavaProgrammerLB:schematics-import-code-issue
Jul 4, 2024
Merged

fix(module:schematics): import RouterLink#8621
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
JavaProgrammerLB:schematics-import-code-issue

Conversation

@JavaProgrammerLB
Copy link
Contributor

Every time 'side-menu' is chosen when adding ng-zorro-antd into Angular project, app.component.html uses RouterLink in Dashboard/welcome router, but the Routerlink is not imported in app.component.ts, I have to import RouterLink in app.component.html whenever I create a new project.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

  1. Choose sidemenu when import ng-zorro-antd
截屏2024-07-02 10 09 52
  1. the generated app.component.html used 'RouterLink' without 'RouterLink' in import code block
截屏2024-07-02 10 13 10
  1. The 'RouterLink' is missed
截屏2024-07-02 10 17 00

What is the new behavior?

import RouterLink

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Every time 'side-menu' is chosen when adding ng-zorro-antd into Angular project, app.component.html uses RouterLink in Dashboard/welcome router, but the Routerlink is not imported in app.component.ts
@codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (589a842) to head (e156ddf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8621      +/-   ##
==========================================
- Coverage   91.51%   91.50%   -0.02%     
==========================================
  Files         534      534              
  Lines       18425    18425              
  Branches     2905     2905              
==========================================
- Hits        16862    16860       -2     
- Misses       1243     1244       +1     
- Partials      320      321       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants