fix(module:schematics): import RouterLink#8621
Merged
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom Jul 4, 2024
Merged
Conversation
Every time 'side-menu' is chosen when adding ng-zorro-antd into Angular project, app.component.html uses RouterLink in Dashboard/welcome router, but the Routerlink is not imported in app.component.ts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8621 +/- ##
==========================================
- Coverage 91.51% 91.50% -0.02%
==========================================
Files 534 534
Lines 18425 18425
Branches 2905 2905
==========================================
- Hits 16862 16860 -2
- Misses 1243 1244 +1
- Partials 320 321 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time 'side-menu' is chosen when adding ng-zorro-antd into Angular project, app.component.html uses RouterLink in Dashboard/welcome router, but the Routerlink is not imported in app.component.ts, I have to import RouterLink in app.component.html whenever I create a new project.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
import RouterLink
Does this PR introduce a breaking change?
Other information