Skip to content

fix(module:cascader): hide placeholder when trigger compositionstart#8641

Merged
Laffery merged 2 commits intoNG-ZORRO:masterfrom
Zz-ZzzZ:fix-cascader
Jul 22, 2024
Merged

fix(module:cascader): hide placeholder when trigger compositionstart#8641
Laffery merged 2 commits intoNG-ZORRO:masterfrom
Zz-ZzzZ:fix-cascader

Conversation

@Zz-ZzzZ
Copy link
Copy Markdown
Contributor

@Zz-ZzzZ Zz-ZzzZ commented Jul 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #8533

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Zz-ZzzZ Zz-ZzzZ requested a review from wzhudev as a code owner July 18, 2024 07:49
@zorro-bot
Copy link
Copy Markdown

zorro-bot bot commented Jul 18, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (20bb5b2) to head (7ed423d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8641      +/-   ##
==========================================
- Coverage   91.52%   91.51%   -0.01%     
==========================================
  Files         535      535              
  Lines       18411    18416       +5     
  Branches     2904     2904              
==========================================
+ Hits        16850    16853       +3     
- Misses       1241     1242       +1     
- Partials      320      321       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zz-ZzzZ Zz-ZzzZ changed the title fix(module:cascader): hide placeholder when trigger compositionStart fix(module:cascader): hide placeholder when trigger compositionstart Jul 19, 2024
Copy link
Copy Markdown
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 17b0ea3 into NG-ZORRO:master Jul 22, 2024
@Zz-ZzzZ Zz-ZzzZ deleted the fix-cascader branch July 22, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants