fix(module:datepicker): ng0956 recreation entire collection#8658
Merged
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom Jul 31, 2024
Merged
fix(module:datepicker): ng0956 recreation entire collection#8658HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
Conversation
|
This preview will be available after the AzureCI is passed. |
bd30c56 to
17d7f98
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8658 +/- ##
==========================================
- Coverage 91.53% 91.52% -0.01%
==========================================
Files 536 536
Lines 18445 18447 +2
Branches 2907 2907
==========================================
+ Hits 16883 16884 +1
- Misses 1242 1243 +1
Partials 320 320 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Due to the refactor of the control flow of this component, an issue was raised. NG0956, this issue is a warning raised when a collection of a loop is re create each time on render. This is due to a wrong track parameters
Issue Number: #8653
What is the new behavior?
NG0956 is fixed
Does this PR introduce a breaking change?
Other information