feat(module:datepicker): send event emitter when panel mode change#8685
Merged
Conversation
Nicoss54
requested review from
HyperLife1119 and
simplejason
and removed request for
wenqi73
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8685 +/- ##
==========================================
+ Coverage 91.54% 91.58% +0.03%
==========================================
Files 536 538 +2
Lines 18443 18459 +16
Branches 2907 2816 -91
==========================================
+ Hits 16883 16905 +22
+ Misses 1241 1237 -4
+ Partials 319 317 -2 ☔ View full report in Codecov by Sentry. |
HyperLife1119
requested changes
Aug 7, 2024
Nicoss54
force-pushed
the
feature/month-year-change
branch
from
8828ad3 to
14a6ce7
Compare
Collaborator
Author
|
@HyperLife1119 all is done |
Collaborator
Author
|
@HyperLife1119 change are made :) |
HyperLife1119
added
PR: partially-approved
and removed
PR: reviewed-changes-requested
labels
azimtechie
approved these changes
Aug 12, 2024
azimtechie
approved these changes
Aug 12, 2024
azimtechie
approved these changes
Aug 12, 2024
Laffery
reviewed
Aug 17, 2024
Laffery
reviewed
Aug 17, 2024
| export type NzPanelChangeType = | ||
| | { mode: NzDateMode; date: Date } | ||
| | { | ||
| mode: [starMode: NzDateMode, endMode: NzDateMode]; |
Laffery
reviewed
Aug 18, 2024
Nicoss54
force-pushed
the
feature/month-year-change
branch
from
cf30232 to
8f87cb8
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently panel mode change event is not sent when user click on the arrow on the header panel of the datepicker.
This is not the same behavior of the ant design. When user click on the arrow we must send the new mode and the date
Issue Number: #8648
What is the new behavior?
An event is sent each time user click on an arrow, and the event send the information as an object
{ date, mode }
Does this PR introduce a breaking change?
Other information