Skip to content

fix(module:carousel): delete unnecessary logic (#6942)#8705

Merged
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
Gornachok:fix/carousel-rtl
Nov 7, 2024
Merged

fix(module:carousel): delete unnecessary logic (#6942)#8705
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
Gornachok:fix/carousel-rtl

Conversation

@Gornachok
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #6942

What is the new behavior?

Carousel dots and slick-active class works fine now in RTL

Does this PR introduce a breaking change?

  • Yes
  • No

@Gornachok Gornachok requested a review from wzhudev as a code owner August 22, 2024 00:09
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (175f47b) to head (f67c2ed).
Report is 83 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8705      +/-   ##
==========================================
+ Coverage   91.53%   91.55%   +0.02%     
==========================================
  Files         538      538              
  Lines       18441    18435       -6     
  Branches     2816     2814       -2     
==========================================
- Hits        16880    16879       -1     
+ Misses       1242     1239       -3     
+ Partials      319      317       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit 85f23a1 into NG-ZORRO:master Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants