feat(module:input): support one time password (OTP)#8715
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8715 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 546 547 +1
Lines 19291 19383 +92
Branches 2850 2866 +16
==========================================
+ Hits 17728 17812 +84
- Misses 1251 1255 +4
- Partials 312 316 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
HyperLife1119
added
PR: partially-approved
⭐ New Component
and removed
PR: reviewed-changes-requested
labels
|
Hi @Laffery |
OK 👌 |
| expect(callback).toHaveBeenCalledWith('test value'); | ||
| }); | ||
|
|
||
| it('should register onTouched callback', () => { |
There was a problem hiding this comment.
These methods are implementation of ControlValueAccessor interface, which is well tested by angular.
I think we needn't to write test cases for them, WDYT?
There was a problem hiding this comment.
You're absolutely right—logically, these parts shouldn't need to be tested again. However, for some reason, Karma can't recognize that they are part of Angular and expects us to test them. By removing these two tests, we would lose some code coverage. What’s your take on this?
Laffery
changed the title
|
Hi, @ParsaArvanehPA I had reviewed and left several comments, please take a look |
Hi @Laffery |
Laffery
added
PR: reviewed-approved
and removed
PR: reviewed-changes-requested
PR: partially-approved
labels
3 participants
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Implementation of the OTP component of the Ant Desgin
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Since we are currently on the fourth version of Ant, and the varient section is one of the changes made to the input component in the fifth version, this part is not currently implemented.