Skip to content

feat(module:transfer): use nzOneWay to make Transfer the one way style#8717

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
OriginRing:feat/transfer-oneWay
Nov 20, 2024
Merged

feat(module:transfer): use nzOneWay to make Transfer the one way style#8717
Laffery merged 1 commit into
NG-ZORRO:masterfrom
OriginRing:feat/transfer-oneWay

Conversation

@OriginRing

@OriginRing OriginRing commented Aug 28, 2024

Copy link
Copy Markdown
Collaborator

fix: #8643

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@OriginRing OriginRing requested a review from Ricbet as a code owner August 28, 2024 04:21
@zorro-bot

zorro-bot Bot commented Aug 28, 2024

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Aug 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.13%. Comparing base (9e3bb3e) to head (4809583).
Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
components/transfer/transfer-list.component.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8717      +/-   ##
==========================================
- Coverage   93.15%   93.13%   -0.02%     
==========================================
  Files         538      538              
  Lines       18457    18464       +7     
  Branches     2816     2816              
==========================================
+ Hits        17193    17197       +4     
- Misses       1226     1229       +3     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@OriginRing OriginRing requested a review from Laffery August 28, 2024 06:10
Comment thread components/transfer/transfer-list.component.ts Outdated

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread components/transfer/demo/on-way.ts Outdated
Comment thread components/transfer/transfer-list.component.ts Outdated
@HyperLife1119

HyperLife1119 commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator

Please fix the CI :)

@HyperLife1119 HyperLife1119 added PR: need-test Test is necessary for code changes. and removed PR: reviewed-changes-requested labels Sep 10, 2024
@HyperLife1119 HyperLife1119 added this to the v19 milestone Sep 11, 2024
@HyperLife1119 HyperLife1119 removed the PR: need-test Test is necessary for code changes. label Sep 20, 2024

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 99fd4de into NG-ZORRO:master Nov 20, 2024
@OriginRing OriginRing deleted the feat/transfer-oneWay branch March 5, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transfer 支持单向样式

3 participants