fix(module:modal,drawer): secondary overlays not scrolling inside#8804
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8804 +/- ##
==========================================
- Coverage 91.77% 91.76% -0.01%
==========================================
Files 536 536
Lines 18455 18455
Branches 2816 2816
==========================================
- Hits 16937 16936 -1
Misses 1209 1209
- Partials 309 310 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Sep 28, 2024
This was referenced Sep 28, 2024
This was
linked to
issues
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, when a component, such as the select component, is created using the CDK Overlay within another component that also utilizes CDK Overlay (like a modal or drawer), there is an issue with the positioning during scrolling. Specifically, the first component's position remains fixed and does not adjust to its parent. This behavior occurs because the CDK Overlay, by default, listens for scroll events on the window, which prevents the 'ConnectedPositionStrategy' from detecting changes in position effectively.
To address this issue, we simply need to configure the CDK to listen for scroll events not on the window, but on the secondary overlay. This can be accomplished by using the
cdkScrollabledirective.Issue Number: #7430, #7695, #7865, #8799, #7528, #7528, #7003
What is the new behavior?
fixed the issue mentioned above.
Does this PR introduce a breaking change?
Other information