fix(module:*): cancel support for HTML string rendering#8831
Merged
Conversation
5df9ccd to
2186351
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8831 +/- ##
==========================================
+ Coverage 91.84% 91.88% +0.03%
==========================================
Files 537 547 +10
Lines 18472 19363 +891
Branches 2815 2866 +51
==========================================
+ Hits 16965 17791 +826
- Misses 1204 1256 +52
- Partials 303 316 +13 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
2186351 to
b28c291
Compare
b28c291 to
eedb2de
Compare
Laffery
requested changes
Nov 23, 2024
eedb2de to
aa08d62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
移除一些组件内部支持渲染 HTML 字符串的功能,因为这是非良好的模式。message, notification,modal 组件除外,因为这些组件可以通过 service 方式创建,渲染 html 字符串的用例会比较多。
Does this PR introduce a breaking change?
Other information