Skip to content

fix(module:*): cancel support for HTML string rendering#8831

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
HyperLife1119:fix/avoid-html
Nov 25, 2024
Merged

fix(module:*): cancel support for HTML string rendering#8831
Laffery merged 1 commit into
NG-ZORRO:masterfrom
HyperLife1119:fix/avoid-html

Conversation

@HyperLife1119
Copy link
Copy Markdown
Collaborator

@HyperLife1119 HyperLife1119 commented Oct 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

移除一些组件内部支持渲染 HTML 字符串的功能,因为这是非良好的模式。message, notification,modal 组件除外,因为这些组件可以通过 service 方式创建,渲染 html 字符串的用例会比较多。

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@HyperLife1119 HyperLife1119 added 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: unreviewed PR: target-major labels Oct 9, 2024
@HyperLife1119 HyperLife1119 added this to the v19 milestone Oct 9, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (5fec53e) to head (aa08d62).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
components/date-picker/lib/date-table.component.ts 0.00% 2 Missing ⚠️
...mponents/date-picker/lib/decade-table.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8831      +/-   ##
==========================================
+ Coverage   91.84%   91.88%   +0.03%     
==========================================
  Files         537      547      +10     
  Lines       18472    19363     +891     
  Branches     2815     2866      +51     
==========================================
+ Hits        16965    17791     +826     
- Misses       1204     1256      +52     
- Partials      303      316      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HyperLife1119 HyperLife1119 marked this pull request as draft October 9, 2024 03:40
@HyperLife1119 HyperLife1119 marked this pull request as ready for review October 10, 2024 07:12
@HyperLife1119 HyperLife1119 requested a review from Laffery October 10, 2024 07:13
Comment thread components/slider/marks.component.ts Outdated
Comment thread components/date-picker/lib/abstract-table.html Outdated
Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: reviewed-approved PR: target-major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants