feat(module:tabs): support destroyInactiveTabPane input#8845
Merged
Laffery merged 1 commit intoNG-ZORRO:masterfrom Oct 22, 2024
Merged
feat(module:tabs): support destroyInactiveTabPane input#8845Laffery merged 1 commit intoNG-ZORRO:masterfrom
Laffery merged 1 commit intoNG-ZORRO:masterfrom
Conversation
|
This preview will be available after the AzureCI is passed. |
HyperLife1119
force-pushed
the
feat/tab-destroyInactiveTabPane
branch
from
81436d2 to
a89aed0
Compare
HyperLife1119
force-pushed
the
feat/tab-destroyInactiveTabPane
branch
from
a89aed0 to
e1ec561
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8845 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 536 537 +1
Lines 18455 18456 +1
Branches 2816 2816
=======================================
+ Hits 16967 16968 +1
Misses 1183 1183
Partials 305 305 ☔ View full report in Codecov by Sentry. |
HyperLife1119
force-pushed
the
feat/tab-destroyInactiveTabPane
branch
from
e1ec561 to
104d621
Compare
14 tasks
HyperLife1119
commented
Oct 22, 2024
| it('should load content on first change detection pass', () => { | ||
| fixture.detectChanges(); | ||
| expect(element.querySelectorAll('.ant-tabs-tabpane')[1]!.textContent).toContain(`Content of Tab Pane 1`); | ||
| expect(element.querySelectorAll('.ant-tabs-tabpane')[0]!.textContent).toContain(`Content of Tab Pane 1`); |
Collaborator
Author
There was a problem hiding this comment.
默认情况下只会渲染当前激活或曾经激活过的 tab，由于这里是第一次渲染，所以仅会渲染一个 tab，因此将 index 改为 0
HyperLife1119
force-pushed
the
feat/tab-destroyInactiveTabPane
branch
from
d61915a to
104d621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #8591
What is the new behavior?
Does this PR introduce a breaking change?
Other information