Skip to content

fix(module:drawer): emit nzVisibleChange when close on navigation#8850

Merged
Laffery merged 1 commit intoNG-ZORRO:masterfrom
HyperLife1119:fix/drawer-nzVisibleChange-not-emit-when-nzCloseOnNavigation
Nov 1, 2024
Merged

fix(module:drawer): emit nzVisibleChange when close on navigation#8850
Laffery merged 1 commit intoNG-ZORRO:masterfrom
HyperLife1119:fix/drawer-nzVisibleChange-not-emit-when-nzCloseOnNavigation

Conversation

@HyperLife1119
Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #8719

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zorro-bot
Copy link
Copy Markdown

zorro-bot bot commented Oct 28, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (68f6324) to head (4159848).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
components/drawer/drawer.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8850      +/-   ##
==========================================
- Coverage   91.94%   91.92%   -0.03%     
==========================================
  Files         537      537              
  Lines       18455    18456       +1     
  Branches     2816     2816              
==========================================
- Hits        16969    16966       -3     
- Misses       1182     1185       +3     
- Partials      304      305       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 29827df into NG-ZORRO:master Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants